[PATCH] D105687: [Debug-Info] [llvm-dwarfdump] Don't use DW_FORM_data4/8 to encode the constants for DW_AT_data_member_location.

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 22 06:25:21 PDT 2021


probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

One comment tweak needed, and LGTM.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:1624
+      // interpreted as location-list pointers. Interpretating constants into
+      // pointers is not expected, so we use DW_FORM_udata to encode the
+      // constants here.
----------------
"Interpreting constants as pointers..."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105687/new/

https://reviews.llvm.org/D105687



More information about the llvm-commits mailing list