[PATCH] D105613: [Debug-Info] [llvm-dwarfdump] Don't try to dump location list for attributes that don't have the loclist class.

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/test/tools/llvm-dwarfdump/ELF/formclass3.s:7
+# RUN: llvm-mc %s -filetype obj -triple powerpc64le-unknown-unknown -o %t.o
+# RUN: llvm-dwarfdump -debug-info %t.o | FileCheck %s
+
----------------
It's more common to pipe the object file instead of writing it to the file system.  The test runs a little faster that way, and across many thousands of tests these little things add up.
```
# RUN: llvm-mc ... -o - | llvm-dwarfdump -debug-info - | FileCheck %s
```



================
Comment at: llvm/test/tools/llvm-dwarfdump/ELF/formclass3.s:14
+
+# RUN: llvm-mc %s -filetype obj -triple powerpc64le-unknown-unknown -o %t.o
+# RUN: llvm-dwarfdump -debug-info %t.o | FileCheck %s -check-prefix=AT-COUNT
----------------
Esme wrote:
> probinson wrote:
> > If you simplify the source to have no executable instructions, then I *think* you can remove the `-triple` which will allow this test to be run in all environments.  (A number of bots do not build all targets, so it's preferable to have tests be as generic as possible.)
> Some targets, like AIX, have not yet supported llvm-mc. So I think we should still keep the `-triple`?
If you keep `-triple` then you need a `REQUIRES` to restrict the test to bots that include the correct target.  A number of bots do not build all targets.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105613/new/

https://reviews.llvm.org/D105613