[PATCH] D106039: [AArch64] Fix i128 cmpxchg using ldxp/stxp.

Thu Jul 22 00:32:36 PDT 2021

samparker added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:17058

+  unsigned Opcode;
+  switch (MemOp->getMergedOrdering()) {
----------------
efriedma wrote:
> samparker wrote:
> > efriedma wrote:
> > > MaskRay wrote:
> > > > This was unused.  I deleted it in 2b79a4eeb101bc9662427353187e35b9bc9da116 to pacify -Wunused-but-set-variable
> > > Fixed it to do what I meant to do in 664a1fd9f04de65f0a37d612845dc9e095abe067
> > > 
> > > @samparker Let me know if you want me to add more test coverage.
> > Ah! Yes please, hard enough to get this stuff right so probably worth adding cases for the other orderings...
> 301b21a941ebd94cef2f1912a547960223983887
cheers!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106039/new/

https://reviews.llvm.org/D106039