[PATCH] D106453: [ms] [llvm-ml] Fix macro case-insensitivity

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 21 23:45:02 PDT 2021


mstorsjo added a comment.

LGTM. I presume the test changes are for consistency, making all macros camelcased, and the substitution on line 68 is the only one actually exercising the change.

Would it be good to try a substitution with all lower case too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106453/new/

https://reviews.llvm.org/D106453



More information about the llvm-commits mailing list