[PATCH] D106499: [lld][WebAssembly] Align __heap_base

[Ayke via Phabricator via llvm-commits]

aykevl added a comment.

Thank you for the quick review! I'll commit this soon-ish unless someone has comments on the patch.



================
Comment at: lld/wasm/Writer.cpp:46
 static constexpr int stackAlignment = 16;
+static constexpr int heapBaseAlignment = 8;
 
----------------
sbc100 wrote:
> I think it would make sense to use 16 here since the default ABI has a max_align_t of 16.
> 
> Maybe just call this `heapAlignment`?
Sounds good! I've updated the patch according to your suggestions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106499/new/

https://reviews.llvm.org/D106499