[PATCH] D106499: [lld][WebAssembly] Align __heap_base

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

Nice!  Thanks.



================
Comment at: lld/wasm/Writer.cpp:46
 static constexpr int stackAlignment = 16;
+static constexpr int heapBaseAlignment = 8;
 
----------------
I think it would make sense to use 16 here since the default ABI has a max_align_t of 16.

Maybe just call this `heapAlignment`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106499/new/

https://reviews.llvm.org/D106499