[PATCH] D105703: [hwasan] Use stack safety analysis.

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 21 13:57:02 PDT 2021


vitalybuka added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:410
+    Dummy.setArch(Triple::aarch64);
+    if (shouldUseStackSafetyAnalysis(Dummy, DisableOptimization))
+      AU.addRequired<StackSafetyGlobalInfoWrapperPass>();
----------------
Why not just:
```
if (!DisableOptimization || ClUseStackSafety)
  AU.addRequired<StackSafetyGlobalInfoWrapperPass>();
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105703/new/

https://reviews.llvm.org/D105703



More information about the llvm-commits mailing list