[PATCH] D106292: [flang] Implement the runtime portion of the CSHIFT intrinsic

Wed Jul 21 13:10:05 PDT 2021

mleair accepted this revision.
mleair added a comment.

LGTM

================
Comment at: flang/runtime/transformational.cpp:190
+    SubscriptValue sourceAt{lb + (j + shiftCount) % extent};
+    if (sourceAt < 0) {
+      sourceAt += extent;
----------------
PeteSteinfeld wrote:
> mleair wrote:
> > llvm style recommends no braces for single statement blocks.
> I didn't think that we were following this recommendation for flang code.  This file, in particular is full of single statement blocks that are enclosed by braces.  There's one at line 162, another at line 167, line 232, ...
OK

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106292/new/

https://reviews.llvm.org/D106292