[PATCH] D106443: [IRSim][IROutliner] Adding support for recognizing and outlining branches

[Andrew Litteken via Phabricator via llvm-commits]

AndrewLitteken added inline comments.


================
Comment at: llvm/include/llvm/Analysis/IRSimilarityIdentifier.h:130
 
+  SmallVector<int, 4> RelativeBlockLocations;
+
----------------
Comments needed


================
Comment at: llvm/include/llvm/Analysis/IRSimilarityIdentifier.h:150
 
+  void
+  setBranchSuccessors(DenseMap<BasicBlock *, unsigned> &BasicBlockToInteger);
----------------
Comments needed


================
Comment at: llvm/include/llvm/Analysis/IRSimilarityIdentifier.h:529
 
+  DenseSet<BasicBlock *> BasicBlocks;
+
----------------
Add comments, or convert to method


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:418
   Function::iterator CurrBB, NextBB, FinalBB;
+  // BasicBlock * NewEnds = nullptr;
   std::vector<Instruction *> DebugInsts;
----------------
Not needed anymore


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:1300
                                   Region.GVNStores.end());
+  //errs() << "Num values to find " << ValuesToFind.size() << "\n";
 
----------------
Remove debugging statements


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106443/new/

https://reviews.llvm.org/D106443