[PATCH] D106380: [SystemZ][z/OS] Initial code to generate assembly files on z/OS

Wed Jul 21 09:29:52 PDT 2021

anirudhp marked 2 inline comments as done.
anirudhp added inline comments.

================
Comment at: llvm/test/CodeGen/SystemZ/zos-simple-test.ll:3
+; for the z/OS target
+; RUN: llc < %s -mtriple=s390x-ibm-zos | FileCheck %s
+
----------------
anirudhp wrote:
> tmatheson wrote:
> > The test doesn't seem directly related to the GOFF section code added here. e.g. it doesn't check any section output, but does check an instruction not added in this patch.
> I have added a uninitialized global variable to grep for the .bss section and added a new check string(s) to check for both of them.
In regards to the instruction check, the instruction already exists (we're using existing SystemZ instructions), if the check itself makes it confusing I can remove it. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106380/new/

https://reviews.llvm.org/D106380