[PATCH] D106039: [AArch64] Fix i128 cmpxchg using ldxp/stxp.

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:17058
 
+  unsigned Opcode;
+  switch (MemOp->getMergedOrdering()) {
----------------
efriedma wrote:
> MaskRay wrote:
> > This was unused.  I deleted it in 2b79a4eeb101bc9662427353187e35b9bc9da116 to pacify -Wunused-but-set-variable
> Fixed it to do what I meant to do in 664a1fd9f04de65f0a37d612845dc9e095abe067
> 
> @samparker Let me know if you want me to add more test coverage.
Ah! Yes please, hard enough to get this stuff right so probably worth adding cases for the other orderings...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106039/new/

https://reviews.llvm.org/D106039