[PATCH] D106377: [llvm-symbolizer] Remove one-dash long options

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 20 23:39:05 PDT 2021


MaskRay updated this revision to Diff 360365.
MaskRay added a comment.

fix tests


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106377/new/

https://reviews.llvm.org/D106377

Files:
  llvm/test/tools/llvm-symbolizer/pdb/missing_pdb.test
  llvm/test/tools/llvm-symbolizer/pdb/pdb-columns.test
  llvm/tools/llvm-symbolizer/Opts.td


Index: llvm/tools/llvm-symbolizer/Opts.td
===================================================================
--- llvm/tools/llvm-symbolizer/Opts.td
+++ llvm/tools/llvm-symbolizer/Opts.td
@@ -1,17 +1,17 @@
 include "llvm/Option/OptParser.td"
 
 multiclass B<string name, string help1, string help2> {
-  def NAME: Flag<["--", "-"], name>, HelpText<help1>;
-  def no_ # NAME: Flag<["--", "-"], "no-" # name>, HelpText<help2>;
+  def NAME: Flag<["--"], name>, HelpText<help1>;
+  def no_ # NAME: Flag<["--"], "no-" # name>, HelpText<help2>;
 }
 
 multiclass Eq<string name, string help> {
-  def NAME #_EQ : Joined<["--", "-"], name #"=">,
+  def NAME #_EQ : Joined<["--"], name #"=">,
                   HelpText<help>;
-  def : Separate<["--", "-"], name>, Alias<!cast<Joined>(NAME #_EQ)>;
+  def : Separate<["--"], name>, Alias<!cast<Joined>(NAME #_EQ)>;
 }
 
-class F<string name, string help>: Flag<["--", "-"], name>, HelpText<help>;
+class F<string name, string help>: Flag<["--"], name>, HelpText<help>;
 
 def grp_mach_o : OptionGroup<"kind">,
                  HelpText<"llvm-symbolizer Mach-O Specific Options">;
Index: llvm/test/tools/llvm-symbolizer/pdb/pdb-columns.test
===================================================================
--- llvm/test/tools/llvm-symbolizer/pdb/pdb-columns.test
+++ llvm/test/tools/llvm-symbolizer/pdb/pdb-columns.test
@@ -6,7 +6,7 @@
 RUN: echo 0x140006C30 >> %t.input
 RUN: echo 0x140006C40 >> %t.input
 RUN: echo 0x140006C70 >> %t.input
-RUN:    llvm-symbolizer -obj="%p/Inputs/test-columns.exe" < %t.input \
+RUN:    llvm-symbolizer --obj="%p/Inputs/test-columns.exe" < %t.input \
 RUN:    | FileCheck %s
 
 This tests that the symbolizer outputs column info when it is present in the pdb.
Index: llvm/test/tools/llvm-symbolizer/pdb/missing_pdb.test
===================================================================
--- llvm/test/tools/llvm-symbolizer/pdb/missing_pdb.test
+++ llvm/test/tools/llvm-symbolizer/pdb/missing_pdb.test
@@ -1,4 +1,4 @@
-RUN: llvm-symbolizer 0x401000 0x401001 -obj="%p/Inputs/missing_pdb.exe" 2>%t.err \
+RUN: llvm-symbolizer 0x401000 0x401001 --obj="%p/Inputs/missing_pdb.exe" 2>%t.err \
 RUN:    | FileCheck %s
 RUN: FileCheck -DMSG=%errc_ENOENT --check-prefix=ERROR %s < %t.err
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106377.360365.patch
Type: text/x-patch
Size: 2260 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210721/9035bf67/attachment.bin>


More information about the llvm-commits mailing list