[PATCH] D106235: Reformulate OrcJIT tutorial doc to make it more clear.
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 20 23:00:57 PDT 2021
mehdi_amini added inline comments.
================
Comment at: llvm/docs/tutorial/BuildingAJIT2.rst:232
+and stores it in the target ``JITDylib``, arranging for it to be passed back
+to layer's emit method when someone requests any symbols defined by the module.
+Each layer can complete its own work by calling the ``emit`` method of its base
----------------
I'm not sure this sentence is actually more clear. You're trying to go from a passive form to an active form, but it goes with introducing `someone` as the subject, which does not seem like usual to me when describing some piece of code calling another piece of code.
Are you following some guidelines on technical documentation here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106235/new/
https://reviews.llvm.org/D106235
More information about the llvm-commits
mailing list