[PATCH] D106248: [Coroutines] Overalign coroutine frame when frame alignment exceeds the alignment limit

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 20 22:43:42 PDT 2021


ychen added a comment.

Thanks for the patch. Does it make more sense to compare this with D100739 <https://reviews.llvm.org/D100739> (The implementation details are slightly different but the idea is similar: generating code to handle the overaligned frame in the backend. )? Before actually reviewing this patch, I think a consensus is needed about where to implement this: LLVM or Clang. My preference would be Clang however I think implementing this in LLVM is simpler. I'd appreciate other reviewer's comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106248/new/

https://reviews.llvm.org/D106248



More information about the llvm-commits mailing list