[PATCH] D102834: [SLPVectorizer] Implement initial memory versioning.

[Stephen Long via Phabricator via llvm-commits]

steplong added a comment.

In D102834#2866603 <https://reviews.llvm.org/D102834#2866603>, @SjoerdMeijer wrote:

> Just a bit of a heads up that I took this patch (and it's dependencies) and run some numbers for x264 SPEC, where I have seen quite a few missed opportunities caused by inability to emit runtime alias checks. I don't see any change in performance though, which is slightly unexpected (I was hoping for some already). But it might be that the next thing is blocking SLP vectorisation, for AArch64 which is what I am looking at, and that might be cost-model issues. This is the case for the 2 examples I am currently looking at, but will do some more analysis. And we of course need this patch as an enabler.

I also tried taking this patch and running the numbers for x264 SPEC. I'm also not seeing an improvement in performance. What loops are you specifically look at? I see that the loop you referenced in https://reviews.llvm.org/D102748 is still not vectorized with this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102834/new/

https://reviews.llvm.org/D102834