[PATCH] D106411: [Bazel] Remove explicit relative_to_caller_repository

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey created this revision.
Herald added subscribers: dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini.
GMNGeoffrey requested review of this revision.
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache.
Herald added a project: LLVM.

This is the default and the argument is deprecated. The documentation
indicating it's the default is only since 4.0
(https://docs.bazel.build/versions/4.0.0/skylark/lib/Label.html#Label),
but looking at the code it has been the default since its introduction
in https://bazel.googlesource.com/bazel/+/6f15335dea with Bazel 0.2.1
(https://bazel.googlesource.com/bazel/+show/0.2.1/CHANGELOG.md)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106411

Files:
  utils/bazel/llvm-project-overlay/llvm/tblgen.bzl
  utils/bazel/llvm-project-overlay/mlir/tblgen.bzl


Index: utils/bazel/llvm-project-overlay/mlir/tblgen.bzl
===================================================================
--- utils/bazel/llvm-project-overlay/mlir/tblgen.bzl
+++ utils/bazel/llvm-project-overlay/mlir/tblgen.bzl
@@ -333,10 +333,7 @@
       **kwargs: Extra keyword arguments to pass to all generated rules.
     """
 
-    llvm_project_execroot_path = Label(
-        "//mlir:tblgen.bzl",
-        relative_to_caller_repository = False,
-    ).workspace_root
+    llvm_project_execroot_path = Label("//mlir:tblgen.bzl").workspace_root
 
     # TODO(gcmn): Update callers to td_library and explicit includes and drop
     # this hardcoded include.
Index: utils/bazel/llvm-project-overlay/llvm/tblgen.bzl
===================================================================
--- utils/bazel/llvm-project-overlay/llvm/tblgen.bzl
+++ utils/bazel/llvm-project-overlay/llvm/tblgen.bzl
@@ -35,7 +35,7 @@
       tblgen_args: Extra arguments string to pass to the tblgen binary.
       **kwargs: Keyword arguments to pass to subsidiary cc_library() rule.
     """
-    llvm_project_execroot_path = Label("//llvm:tblgen.bzl", relative_to_caller_repository = False).workspace_root
+    llvm_project_execroot_path = Label("//llvm:tblgen.bzl").workspace_root
 
     if td_file not in td_srcs:
         td_srcs += [td_file]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106411.360318.patch
Type: text/x-patch
Size: 1325 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210720/2b5c42b5/attachment.bin>