[PATCH] D105321: [Bitcode][OpaquePtr] Remove usages of PointerType's getElementType()
Arthur Eubanks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 20 16:22:34 PDT 2021
aeubanks added a comment.
A non-opaque pointer already has its pointee type available, there's no reason to have a separate map.
I was thinking, maybe we should temporarily put aside the goal of removing the pointee type from `PointerType` so that the bitcode upgrade is easier to implement. So we'd keep things mostly as they are in BitcodeReader with calls to `getElementType()`, but we'd have a pass immediately after reading the entire bitcode file that makes all pointer types opaque. This seems very doable and hopefully not complicated.
Then in the future, after the opaque pointer transition, we can consider removing the pointee type and having the Value -> pointee type map in BitcodeReader if we really want to remove the pointee type field in `PointerType`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105321/new/
https://reviews.llvm.org/D105321
More information about the llvm-commits
mailing list