[PATCH] D106291: [AMDGPU] Improve killed check for vgpr optimization

[Ruiling, Song via Phabricator via llvm-commits]

ruiling accepted this revision.
ruiling added a comment.
This revision is now accepted and ready to land.

LGTM with one nit.



================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp:242
+            // Check if the register is live into the endif block. If not,
+            // consider it killed in the then and else branches.
+            LiveVariables::VarInfo &VI = LV->getVarInfo(MOReg);
----------------
I think the comment should be "killed in the else branch" or you can also use "killed in the else region". AFAIK kill in LLVM means the value is dead after some program point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106291/new/

https://reviews.llvm.org/D106291