[llvm] df47770 - [ORC] Explicitly convert to ArrayRefs to silence errors.

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 20 16:18:46 PDT 2021


Oh handy. Thanks Dave!

On Wed, Jul 21, 2021 at 6:36 AM David Blaikie <dblaikie at gmail.com> wrote:

> I think there's a `makeArrayRef` that'd avoid the need to explicitly name
> the element type here - if you like
>
> On Mon, Jul 19, 2021 at 3:49 AM Lang Hames via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>>
>> Author: Lang Hames
>> Date: 2021-07-19T20:48:30+10:00
>> New Revision: df4777060010ead66bd626fbc6ddbadbb2ce4b18
>>
>> URL:
>> https://github.com/llvm/llvm-project/commit/df4777060010ead66bd626fbc6ddbadbb2ce4b18
>> DIFF:
>> https://github.com/llvm/llvm-project/commit/df4777060010ead66bd626fbc6ddbadbb2ce4b18.diff
>>
>> LOG: [ORC] Explicitly convert to ArrayRefs to silence errors.
>>
>> This aims to fix build failures like
>> https://lab.llvm.org/buildbot#builders/165/builds/3761.
>>
>> Added:
>>
>>
>> Modified:
>>     llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp
>>
>> Removed:
>>
>>
>>
>>
>> ################################################################################
>> diff  --git a/llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp
>> b/llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp
>> index 686c3e8c165b..2a6583249cad 100644
>> --- a/llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp
>> +++ b/llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp
>> @@ -229,7 +229,7 @@ MachOPlatform::requiredCXXAliases() {
>>    static const std::pair<const char *, const char *>
>> RequiredCXXAliases[] = {
>>        {"___cxa_atexit", "___orc_rt_macho_cxa_atexit"}};
>>
>> -  return RequiredCXXAliases;
>> +  return ArrayRef<std::pair<const char *, const char
>> *>>(RequiredCXXAliases);
>>  }
>>
>>  ArrayRef<std::pair<const char *, const char *>>
>> @@ -239,7 +239,8 @@ MachOPlatform::standardRuntimeUtilityAliases() {
>>            {"___orc_rt_run_program", "___orc_rt_macho_run_program"},
>>            {"___orc_rt_log_error", "___orc_rt_log_error_to_stderr"}};
>>
>> -  return StandardRuntimeUtilityAliases;
>> +  return ArrayRef<std::pair<const char *, const char *>>(
>> +      StandardRuntimeUtilityAliases);
>>  }
>>
>>  bool MachOPlatform::supportedTarget(const Triple &TT) {
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210721/d77b5d00/attachment.html>


More information about the llvm-commits mailing list