[PATCH] D106385: [lld][WebAssembly] Error on import of TLS symbols in shared libraries

[Sam Clegg via Phabricator via llvm-commits]

sbc100 created this revision.
Herald added subscribers: wingo, ecnelises, jfb, sunfish, jgravelle-google, dschuff.
sbc100 requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

In https://reviews.llvm.org/D102044 we made exporting a TLS symbol
into an error, but we also want to error on import.

See https://github.com/emscripten-core/emscripten/issues/14461


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106385

Files:
  lld/test/wasm/tls-import.s
  lld/wasm/Relocations.cpp


Index: lld/wasm/Relocations.cpp
===================================================================
--- lld/wasm/Relocations.cpp
+++ lld/wasm/Relocations.cpp
@@ -146,6 +146,15 @@
               " cannot be used against symbol " + toString(*sym) +
               "; recompile with -fPIC");
         break;
+      case R_WASM_MEMORY_ADDR_TLS_SLEB:
+      case R_WASM_MEMORY_ADDR_TLS_SLEB64:
+        if (!sym->isDefined()) {
+          error(toString(file) +
+                ": TLS symbol is undefined, but TLS symbols cannot yet be "
+                "imported: `" +
+                toString(*sym) + "`");
+        }
+        break;
       case R_WASM_TABLE_INDEX_I32:
       case R_WASM_TABLE_INDEX_I64:
       case R_WASM_MEMORY_ADDR_I32:
Index: lld/test/wasm/tls-import.s
===================================================================
--- /dev/null
+++ lld/test/wasm/tls-import.s
@@ -0,0 +1,23 @@
+# RUN: llvm-mc -filetype=obj -triple=wasm32-unknown-unknown -o %t.o %s
+# RUN: not wasm-ld -shared --experimental-pic --shared-memory -o %t.wasm %t.o 2>&1 | FileCheck %s
+
+# CHECK: error: {{.*}}.o: TLS symbol is undefined, but TLS symbols cannot yet be imported: `foo`
+
+.globl _start
+_start:
+  .functype _start () -> ()
+  i32.const foo at TLSREL
+  drop
+  end_function
+
+.section  .custom_section.target_features,"",@
+  .int8 3
+  .int8 43
+  .int8 7
+  .ascii  "atomics"
+  .int8 43
+  .int8 11
+  .ascii  "bulk-memory"
+  .int8 43
+  .int8 15
+  .ascii "mutable-globals"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106385.360223.patch
Type: text/x-patch
Size: 1486 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210720/dbbf6936/attachment.bin>