[PATCH] D106139: [AMDGPU] Combine srl of add that intends to get the carry of the add as addcarry

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 20 11:22:52 PDT 2021


arsenm added a comment.

In D106139#2890809 <https://reviews.llvm.org/D106139#2890809>, @abinavpp wrote:

> We can keep this transformation target independent, but which approach should we
> go with: Approach A (DAG-combine) or Approach B (inst-combine)?
>
>   

These aren't mutually exclusive. A huge number of things like this should be implemented in both. I would lean towards the DAG version being more important at the moment


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106139/new/

https://reviews.llvm.org/D106139



More information about the llvm-commits mailing list