[PATCH] D106381: Consolidate string types into ptr and length representations.

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good, with the StdStringKind case reverted/kept separately given its use in toNullTerminatedStringRef.

Thanks!



================
Comment at: llvm/lib/Support/Twine.cpp:33
 
 StringRef Twine::toNullTerminatedStringRef(SmallVectorImpl<char> &Out) const {
+  if (isUnary() && getLHSKind() == CStringKind) {
----------------
Ah, this feature might justify keeping StdStringKind separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106381/new/

https://reviews.llvm.org/D106381