[PATCH] D106228: [LTO] Add SelectionKind to IRSymtab and use it in ld.lld/LLVMgold

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 20 10:24:38 PDT 2021


MaskRay added inline comments.


================
Comment at: lld/COFF/InputFiles.cpp:1070
   for (size_t i = 0; i != obj->getComdatTable().size(); ++i)
     // FIXME: lto::InputFile doesn't keep enough data to do correct comdat
     // selection handling.
----------------
tejohnson wrote:
> Can this FIXME be removed now? Or are there more improvements needed?
Changed the FIXME wording. I'll keep PE/COFF unchanged in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106228/new/

https://reviews.llvm.org/D106228



More information about the llvm-commits mailing list