[PATCH] D106378: RISCV: relax the ABI mismatch checking

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 20 09:57:33 PDT 2021


MaskRay added a comment.

I agree with this comment https://github.com/riscv/riscv-elf-psabi-doc/pull/200#issuecomment-883006301

There is a layering difference. `e_flags` should not need a section header table to provide a diagnostic.
At least from a first glance the GNU ld behavior looks strange to me.

The original intention of this patch is likely the reason I am concerned with so-called compatibility checks (e.g. https://github.com/riscv/riscv-elf-psabi-doc/pull/71) because people may need a way to suppress them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106378/new/

https://reviews.llvm.org/D106378



More information about the llvm-commits mailing list