[PATCH] D105884: [llvm-readobj] Display multiple function names for stack size entries

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/stack-sizes.test:893-895
+# Check that that we see multiple symbols output in cases when multiple symbols
+# share the same stack size entry. For example when use of ICF means two functions
+# are represented by the same code.
----------------
Use `##` for comments in test files.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5814
+    SmallVector<std::string> FuncSymNames;
+    for (uint32_t index : FuncSymIndexes)
+      FuncSymNames.push_back(this->getStaticSymbolName(index));
----------------
jhenderson wrote:
> Nit: fix all the clang-tidy warnings.
Ping: this hasn't been addressed.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5831
+      std::next(FuncNames.begin()), FuncNames.end(), FuncNames.front(),
+      [this](const std::string &AllNames, const std::string &FuncNames) {
+        return AllNames + ", " + FuncNames;
----------------
jhenderson wrote:
> Use `StringRef`, not `const std::string &`.
Ping: this hasn't been addressed (nor has the adjacent clang-tidy issue).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105884/new/

https://reviews.llvm.org/D105884