[PATCH] D106165: [flang][OpenMP] Add semantic check for target nesting

[Peixin Qiao via Phabricator via llvm-commits]

peixin updated this revision to Diff 360040.
peixin set the repository for this revision to rG LLVM Github Monorepo.
peixin added a comment.

@kiranchandramohan Thanks for the review.

The restriction applies to any kind of nesting. Add the test scenario of `parallel` directive between `target` and `target update`, which is not covered in previous design. Fixed the design to cover this scenario. Also rename the function name.

The error reporting is truly not completely reasonable. Change it into warning report and also fix the error info by replacing `cannot` by `should not`. Is this OK with you? @kiranchandramohan @clementval


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106165/new/

https://reviews.llvm.org/D106165

Files:
  flang/lib/Semantics/check-omp-structure.cpp
  flang/lib/Semantics/check-omp-structure.h
  flang/test/Semantics/omp-target01.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106165.360040.patch
Type: text/x-patch
Size: 4811 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210720/d2cde2d3/attachment.bin>