[PATCH] D106341: [OpenMP][FIX] Use name + type checks not only name checks for calls

Shilei Tian via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 19 20:55:16 PDT 2021


tianshilei1992 added a comment.

I didn’t get the idea in the description from the code clearly. The old comparison is still address based. In what scenario that `RFI->Declaration` can be `nullptr`? The only difference might be when `CB->getCalledFunction()` and `RFI.Declarion` are both `nullptr`, which will fail the check now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106341/new/

https://reviews.llvm.org/D106341



More information about the llvm-commits mailing list