[PATCH] D106308: [Local] Do not introduce a new `llvm.trap` before `unreachable`

Mon Jul 19 19:13:15 PDT 2021

jdoerfert added a subscriber: iteratee.
jdoerfert added a comment.

I will XFAIL `llvm/test/CodeGen/Thumb2/ifcvt-rescan-diamonds.ll` as part of this. The test is full of UB and runs O2 <https://reviews.llvm.org/owners/package/2/>, it is not surprising it will eventually break. I tried to make the pointers arguments but that changed the output. The author (@iteratee) seem to be inactive by now and there was no review on phab, I think.
I made a similar comment here: https://reviews.llvm.org/D53450#2889172

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106308/new/

https://reviews.llvm.org/D106308