[PATCH] D105423: Add support for Opaque as a LowLevelType

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/Support/LowLevelTypeImpl.h:334
   uint64_t IsVector : 1;
-  uint64_t RawData : 62;
+  uint64_t RawData : 61;
 
----------------
Leftover change?


================
Comment at: llvm/unittests/CodeGen/LowLevelTypeTest.cpp:24
   DataLayout DL("");
 
+  for (unsigned S : {0U, 1U, 17U, 32U, 64U, 0xfffffU}) {
----------------
I think we're missing an EXPECT_FALSE(LLT().isValid()) test


================
Comment at: llvm/unittests/CodeGen/LowLevelTypeTest.cpp:49
   }
 }
 
----------------
What happens for a vector of opaque?


================
Comment at: llvm/unittests/CodeGen/LowLevelTypeTest.cpp:54
   DataLayout DL("");
 
   for (unsigned S : {1U, 17U, 32U, 64U, 0xfffU}) {
----------------
What happens for a vector of opaque?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105423/new/

https://reviews.llvm.org/D105423