[PATCH] D106291: [AMDGPU] Improve killed check for vgpr optimization

Mon Jul 19 17:28:09 PDT 2021

arsenm added a comment.

In D106291#2889004 <https://reviews.llvm.org/D106291#2889004>, @ruiling wrote:

> In D106291#2888251 <https://reviews.llvm.org/D106291#2888251>, @arsenm wrote:
>
>> Kill flags are deprecated and we should try to avoid using them.
>
> Is there any previous discussion about this? what's the motivation for this?

It's scattered around various review threads. Basically maintaining them is painful and a constant source of verifier errors. A few places still rely on them being accurate. You don't need them if you always analyze liveness looking backwards instead of forwards

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106291/new/

https://reviews.llvm.org/D106291