[PATCH] D106305: [compiler-rt][CMake] create aarch64 helper asm during configure time

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:534
         set(helper_asm "${OA_HELPERS_DIR}/outline_atomic_${pat}${size}_${model}.S")
-        add_custom_command(
-          OUTPUT ${helper_asm}
----------------
Could you pull this out of the loop and keep it a custom command instead?

Doing more stuff in the build and less during cmake time is multicore- and incremental-build-friendlier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106305/new/

https://reviews.llvm.org/D106305