[PATCH] D102039: [profile] Add binary id into profiles

[Gulfem Savrun Yeniceri via Phabricator via llvm-commits]

gulfem marked an inline comment as done.
gulfem added inline comments.


================
Comment at: llvm/lib/ProfileData/InstrProfReader.cpp:537
+      return make_error<InstrProfError>(instrprof_error::malformed);
+  }
+
----------------
davidxl wrote:
> When there is no binary ids to be print, perhaps output a line with 'None' instead of empty (which looks like the output is truncated.
When there is no binary id, we don't print anything at all.
At line 517, we check the binary id size, and if there is no binary id, just return without printing anything.
```
  if (BinaryIdsSize == 0)
    return success();
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102039/new/

https://reviews.llvm.org/D102039