[PATCH] D102039: [profile] Add binary id into profiles

[Gulfem Savrun Yeniceri via Phabricator via llvm-commits]

gulfem marked an inline comment as done.
gulfem added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingPlatformLinux.c:92
+  int BinaryIdsSize = 0;
+  while (Note < NotesEnd) {
+    /*
----------------
davidxl wrote:
> Is it possible to extract this into a common helper function like
> 
> void ForEachNote(int note_type,  .. note_start, .. note_end,  ... call_back ) {
>   ...
> 
> }
I think your concern was about the readability of that function, so I broke that function into multiple functions to increase readability.
Please let me know if you other concerns.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102039/new/

https://reviews.llvm.org/D102039