[PATCH] D106319: [IR] Rename `comdat noduplicates` to `comdat nodeduplicate`
    Reid Kleckner via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Jul 19 15:40:53 PDT 2021
    
    
  
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
So, the reason the current name might feel inaccurate is that if you were writing a linker, you might imagine that two groups with the same name should be a linker error, but that is not in fact the case: it just means that both sets of sections are retained, and later symbol resolution may report duplicate symbols of the same name, if the group happens to contain strong external symbols with the same names.
I'm OK with the renaming.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106319/new/
https://reviews.llvm.org/D106319
    
    
More information about the llvm-commits
mailing list