[PATCH] D106300: [LangRef] Clarify comdat

Mon Jul 19 15:11:13 PDT 2021

MaskRay marked an inline comment as done.
MaskRay added inline comments.

================
Comment at: llvm/docs/LangRef.rst:945
 ``noduplicates``
-    The linker requires that only section with this COMDAT key exist.
+    No deduplication is performed.
 ``samesize``
----------------
dschuff wrote:
> MaskRay wrote:
> > dschuff wrote:
> > > This wording is confusing: the term "noduplicates" seems to be in conflict with the idea that no deduplication is performed (which could result in there being duplicates in the output). Is that intentional? Does it mean that the compiler must ensure that there are no duplicates (which would allow the linker to skip deduplication)? If so, I think ti would be good to clarify.
> > I agree that `noduplicates` is confusing. The word says the opposite to that the implementation actually does...
> > 
> > I will send a patch to renaming it...
> Sounds good. I don't think that needs to block this CL though, if it describes the current situation accurately. I'll let @sbc100 take a look from the wasm side too though.
Sent D106319 to rename `noduplicates` to `nodeduplicate`.

The IR name has the PE origin `IMAGE_COMDAT_SELECT_NODUPLICATES` which IMHO is not an ideal name.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106300/new/

https://reviews.llvm.org/D106300