[PATCH] D104801: [MemCpyOpt] Enable memcpy optimizations unconditionally.

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 19 14:45:52 PDT 2021


tra added a comment.

In D104801#2888266 <https://reviews.llvm.org/D104801#2888266>, @efriedma wrote:

> The one thing I'm concerned about with this change is that we might potentially make a memcpy implementation call memcpy, which seems bad.

Turns out that the patch breaks sanitizers that didn't expect `memset` to materialize when they were compiling their runtime.
https://lab.llvm.org/buildbot/#/builders/37/builds/5453

I've reverted the patch for now and will try again once I figure out how to keep sanitizers happy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104801/new/

https://reviews.llvm.org/D104801



More information about the llvm-commits mailing list