[PATCH] D106300: [LangRef] Clarify comdat
Derek Schuff via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 19 14:35:56 PDT 2021
dschuff added inline comments.
================
Comment at: llvm/docs/LangRef.rst:945
``noduplicates``
- The linker requires that only section with this COMDAT key exist.
+ No deduplication is performed.
``samesize``
----------------
This wording is confusing: the term "noduplicates" seems to be in conflict with the idea that no deduplication is performed (which could result in there being duplicates in the output). Is that intentional? Does it mean that the compiler must ensure that there are no duplicates (which would allow the linker to skip deduplication)? If so, I think ti would be good to clarify.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106300/new/
https://reviews.llvm.org/D106300
More information about the llvm-commits
mailing list