[PATCH] D106309: [LLVM IR] Allow volatile stores to trap.

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:5291
+  if (auto *SI = dyn_cast<StoreInst>(I))
+    return !SI->isVolatile();
+
----------------
This should be sunk into Instruction::willReturn(), otherwise FuncAttrs won't use the new semantics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106309/new/

https://reviews.llvm.org/D106309