[PATCH] D106186: Avoid keeping internal string_views in Twine.

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 19 13:26:10 PDT 2021


dexonsmith accepted this revision.
dexonsmith added a comment.

In D106186#2885180 <https://reviews.llvm.org/D106186#2885180>, @dblaikie wrote:

> Looks good to me, with the (ptr, length) ctor made private.
>
> @dexonsmith could you double check this & see if it sounds reasonable?

LGTM too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106186/new/

https://reviews.llvm.org/D106186



More information about the llvm-commits mailing list