[PATCH] D106291: [AMDGPU] Improve killed check for vgpr optimization

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Kill flags are deprecated and we should try to avoid using them. Register liveness should start at the bottom of the block and scan backwards for defs



================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp:246
+              // branches.
+              LiveVariables::VarInfo &VI = LV->getVarInfo(MOReg);
+              if (VI.isLiveIn(*Endif, MOReg, *MRI)) {
----------------
Shouldn't this give the same result even if it is killed? Do you really need to check it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106291/new/

https://reviews.llvm.org/D106291