[PATCH] D106299: [Local] Flag to decide if a trap should be placed before unreachable

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D106299#2888120 <https://reviews.llvm.org/D106299#2888120>, @lebedev.ri wrote:

> I think `TrapBeforeUnreachableChoice` should be a TTI hook, overrided by GPU targets.

While I don't mind that in general, I figured "always" is a nice debugging option and should be exposed. Not sure what a nice way would be to get both things.

> I think `shouldUseTrapBeforeUnreachable()` should be sunk into `changeToUnreachable()`, and `UseLLVMTrap` renamed into `PreferToUseLLVMTrap`, with an appropriate documentation opdate.

I can do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106299/new/

https://reviews.llvm.org/D106299