[PATCH] D106246: [sanitizer] Place module_ctor/module_dtor in llvm.used

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 19 12:18:02 PDT 2021


MaskRay added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:387
     CtorFunc->setLinkage(GlobalValue::WeakODRLinkage);
-    appendToUsed(M, CtorFunc);
   }
----------------
vitalybuka wrote:
> why we don't need this one?
llvm::createSanitizerCtor has `appendToUsed`, so this is now redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106246/new/

https://reviews.llvm.org/D106246



More information about the llvm-commits mailing list