[PATCH] D106295: [Bazel] Update for 6103fdfab4

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D106295#2888023 <https://reviews.llvm.org/D106295#2888023>, @GMNGeoffrey wrote:

> In D106295#2888015 <https://reviews.llvm.org/D106295#2888015>, @dblaikie wrote:
>
>> Generally if something's sent for review, it should wait until it's approved before committing - but not everything needs to be sent for review. Changes to the Bazel BUILD files seem to be fine to be committed directly/for post commit review, especially by you :)
>
> Ah I was seeking post-commit review, but wanted to land this trivial fix to unbreak things. What is the right way to say "please review this post-commit" then?

I sometimes include some callout in the commit message "I'm open to other ideas/feedback" or the like (were there any particular questions/aspects of review you wanted to get a second set of eyes on?) - or a reply to the commit email (or on the phab commit entry - though personally I prefer the commit email, since that's the authoritative record & replying to the phab commit entry creates a completely different email thread/subject line, etc)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106295/new/

https://reviews.llvm.org/D106295