[PATCH] D106157: [MLGO] Use binary protobufs for improved training performance.

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin marked an inline comment as done.
mtrofin added inline comments.


================
Comment at: llvm/CMakeLists.txt:796-804
+  execute_process(COMMAND 
+    ${Python3_EXECUTABLE} "-m" "pip" "show" "tensorflow" 
+    OUTPUT_VARIABLE TF_PIP_OUT)
+  if ("${TF_PIP_OUT}" STREQUAL "")
+    message(FATAL ERROR "Tensorflow pip package is also required for 'development' mode (protobuf headers)")
+  endif()
+  string(REGEX MATCH "Location: ([^\n]*\n)" TF_PIP_LOC "${TF_PIP_OUT}")
----------------
phosek wrote:
> Can we also provide a way to pass this as a CMake variable? In our case calling `pip` may not work.
Ya, let's use TF_PROTO_HEADERS?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106157/new/

https://reviews.llvm.org/D106157