[PATCH] D106148: [NewPM] Fix wrong perfect forwardings

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 19 08:32:22 PDT 2021


aeubanks added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Scalar/LoopPassManager.h:136
     IsLoopNestPass.push_back(false);
     LoopPasses.emplace_back(new RepeatedLoopPassModelT(std::move(Pass)));
   }
----------------
forward?


================
Comment at: llvm/include/llvm/Transforms/Scalar/LoopPassManager.h:148
     LoopNestPasses.emplace_back(
         new RepeatedLoopNestPassModelT(std::move(Pass)));
   }
----------------
forward?


================
Comment at: llvm/include/llvm/Transforms/Scalar/LoopPassManager.h:490
   bool LoopNestMode = (LPM.getNumLoopPasses() == 0);
   return FunctionToLoopPassAdaptor(std::make_unique<PassModelT>(std::move(LPM)),
                                    UseMemorySSA, UseBlockFrequencyInfo,
----------------
forward?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106148/new/

https://reviews.llvm.org/D106148



More information about the llvm-commits mailing list