[PATCH] D105798: [docs]Examples to show implementation of GISel in AArch64

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/docs/GlobalISel/AArch64examples.rst:22
+To lower incoming arguments.
+.. code-block:: none
+   bool AArch64CallLowering::lowerFormalArguments(
----------------
pooja2299 wrote:
> paquette wrote:
> > I think that this code sample may rot over time. I think it would be better to describe, at a high level
> > 
> > - What lowering incoming arguments means
> > - What must be done to lower incoming arguments
> > 
> > And then say "see `AArch64CallLowering::lowerFormalArguments`" for a sample.
> okk
I agree, this will bitrot and is also too specific to AArch64


================
Comment at: llvm/docs/GlobalISel/AArch64examples.rst:130
+
+      for (unsigned i = 0; i < SplitEVTs.size(); ++i) {
+         if (TLI.getNumRegistersForCallingConv(Ctx, CC, SplitEVTs[i]) > 1) {
----------------
Most of this stuff shouldn't really be here, the generic code should be handling this so it's not great to say this is how you should handle returns


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105798/new/

https://reviews.llvm.org/D105798