[PATCH] D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:505-506
+  } else if (getContext().getTargetInfo().hasFeature("sve")) {
+    CurFn->addFnAttr(
+        llvm::Attribute::getWithVScaleRangeArgs(getLLVMContext(), 0, 16));
   }
----------------
bsmith wrote:
> Is this really what we want? Won't this enable fixed length codegen all of the time?
Fixed length codegen is tied to the minimum `vscale` value, so by using `0` here means nothing is known about the minimum `vscale` and thus fixed length codegen will be restricted to 128bit as is the case when no attribute is specified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106277/new/

https://reviews.llvm.org/D106277