[PATCH] D105432: [Analysis] Add simple cost model for strict (in-order) reductions
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 19 07:30:27 PDT 2021
RKSimon added inline comments.
================
Comment at: llvm/test/Analysis/CostModel/X86/reduce-fadd.ll:146
+ %V16 = call fast float @llvm.vector.reduce.fadd.v16f32(float %arg, <16 x float> undef)
+ %V32 = call fast float @llvm.vector.reduce.fadd.v32f32(float %arg, <32 x float> undef)
ret void
----------------
david-arm wrote:
> RKSimon wrote:
> > please can you remove this change now that we have this test coverage below
> Hi @RKSimon, the problem is that if I revert the change the tests fail. This is because we were previously calling the intrinsic without `fast`, which means that we choose the very expensive cost for an ordered reduction. If you're happy I can remove the `fast` attribute, but I will then have to update all of the costs?
Yes please - the update_analyze_test_checks.py script should do it all for you
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105432/new/
https://reviews.llvm.org/D105432
More information about the llvm-commits
mailing list