[PATCH] D106269: [Polly][Isl] Stop using isl::set::lex_le_set. NFC

[Riccardo Mori via Phabricator via llvm-commits]

patacca created this revision.
Herald added a reviewer: bollu.
Herald added a subscriber: bmahjour.
patacca edited the summary of this revision.
patacca added a reviewer: Meinersbur.
patacca added a project: Polly.
patacca published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This is part of an effort to reduce the differences between the custom C++ bindings used right now by polly in `lib/External/isl/include/isl/isl-noxceptions.h` and the official isl C++ interface.

Changes made:

- Stop using `isl::set::lex_le_set`. The official way to do this is to use `isl::map::lex_le_at`
- Removed `isl::set::lex_le_set` from `isl-noexceptions.h`
- `isl-noexceptions.h` has been generated by this https://github.com/patacca/isl/commit/266fea1d3dbd31c23d866eb363fcc8e61e50419f


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106269

Files:
  polly/lib/Analysis/DependenceInfo.cpp
  polly/lib/External/isl/include/isl/isl-noexceptions.h


Index: polly/lib/External/isl/include/isl/isl-noexceptions.h
===================================================================
--- polly/lib/External/isl/include/isl/isl-noexceptions.h
+++ polly/lib/External/isl/include/isl/isl-noexceptions.h
@@ -2869,7 +2869,6 @@
   inline boolean is_wrapping() const;
   inline isl::map lex_ge_set(isl::set set2) const;
   inline isl::map lex_gt_set(isl::set set2) const;
-  inline isl::map lex_le_set(isl::set set2) const;
   inline isl::map lex_lt_set(isl::set set2) const;
   inline isl::set lexmax() const;
   inline isl::pw_multi_aff lexmax_pw_multi_aff() const;
@@ -16007,12 +16006,6 @@
   return manage(res);
 }
 
-isl::map set::lex_le_set(isl::set set2) const
-{
-  auto res = isl_set_lex_le_set(copy(), set2.release());
-  return manage(res);
-}
-
 isl::map set::lex_lt_set(isl::set set2) const
 {
   auto res = isl_set_lex_lt_set(copy(), set2.release());
Index: polly/lib/Analysis/DependenceInfo.cpp
===================================================================
--- polly/lib/Analysis/DependenceInfo.cpp
+++ polly/lib/Analysis/DependenceInfo.cpp
@@ -673,7 +673,13 @@
   isl::union_set UDeltas = Dependences.deltas();
   isl::set Deltas = singleton(UDeltas, ScheduleSpace);
 
-  isl::map NonPositive = Deltas.lex_le_set(Zero);
+  isl::space Space = Deltas.get_space();
+  isl::map NonPositive = isl::map::universe(Space.map_from_set());
+  NonPositive =
+      NonPositive.lex_le_at(isl::multi_pw_aff::identity_on_domain(Space));
+  NonPositive = NonPositive.intersect_domain(Deltas);
+  NonPositive = NonPositive.intersect_range(Zero);
+
   return NonPositive.is_empty();
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106269.359761.patch
Type: text/x-patch
Size: 1631 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210719/ab5154b6/attachment.bin>