[PATCH] D105978: [SVE][IR] Fix Binary op matching in PatternMatch::m_VScale

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 19 01:51:41 PDT 2021


sdesmalen accepted this revision.
sdesmalen added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/unittests/IR/PatternMatch.cpp:1649
+
+  Type *VecTy2 = ScalableVectorType::get(IRB.getInt8Ty(), 2);
+  Value *NullPtrVec2 = Constant::getNullValue(VecTy2->getPointerTo());
----------------
nit: Can you add a comment saying that this used to cause an assertion-failure before this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105978/new/

https://reviews.llvm.org/D105978



More information about the llvm-commits mailing list